additions to nme-standard branch#754
Merged
Merged
Conversation
Most projects that thoughtbot is working on currently did not start here. The "Use standard" recommendation comes from a time that that wasn't true. There are a few reasons not to use Standard in existing projects: - A large project does not already use Standard and retrofitting would be costly - Need or want Rubocop rules other than Standard's opinionated set
vburzynski
added a commit
that referenced
this pull request
May 9, 2025
* Use an opinionated set of rules for Rubocop Most projects that thoughtbot is working on currently did not start here. The "Use standard" recommendation comes from a time that that wasn't true. There are a few reasons not to use Standard in existing projects: - A large project does not already use Standard and retrofitting would be costly - Need or want Rubocop rules other than Standard's opinionated set * additions to nme-standard branch (#754) * Use an opinionated set of rules for Rubocop Most projects that thoughtbot is working on currently did not start here. The "Use standard" recommendation comes from a time that that wasn't true. There are a few reasons not to use Standard in existing projects: - A large project does not already use Standard and retrofitting would be costly - Need or want Rubocop rules other than Standard's opinionated set * link rubocop guideline to additional information * fix typos and add trade-offs for using standard --------- Co-authored-by: Neil Carvalho <me@neil.pro> --------- Co-authored-by: Valerie Burzynski <valerie.burzynski@thoughtbot.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.